Remove premature changelog entry for #14170#14215
Conversation
Signed-off-by: Robin Bate Boerop <me@robinbb.com>
|
I think you should just bring back your fix and keep the entry. The macos issue is unrelated. |
The fix is in. This PR does not remove it. The subtlety is that the fix does not fully resolve the issue (though it once attempted to do that). |
Oh, maybe you mean that I should actually fix the issue in the way that we had before (but which failed on mac). Yes, okay. I will do that in addition to merging this issue, which will make things right in the meantime. |
|
Yes. The failure on mac was just bad luck. I've encountered it today in a different PR, and I'm pretty sure I know the source of the bug ( |
Summary
doc/changes/fixed/14170.mdwhich was included prematurely in Send SIGTERM before SIGKILL when shutting down child processes #14170