Skip to content

Remove premature changelog entry for #14170#14215

Merged
robinbb merged 1 commit intomainfrom
remove-14170-changelog
Apr 17, 2026
Merged

Remove premature changelog entry for #14170#14215
robinbb merged 1 commit intomainfrom
remove-14170-changelog

Conversation

@robinbb
Copy link
Copy Markdown
Collaborator

@robinbb robinbb commented Apr 17, 2026

Summary

Signed-off-by: Robin Bate Boerop <me@robinbb.com>
@robinbb robinbb requested a review from Alizter April 17, 2026 17:58
@rgrinberg
Copy link
Copy Markdown
Member

I think you should just bring back your fix and keep the entry. The macos issue is unrelated.

@robinbb
Copy link
Copy Markdown
Collaborator Author

robinbb commented Apr 17, 2026

I think you should just bring back your fix and keep the entry. The macos issue is unrelated.

The fix is in. This PR does not remove it. The subtlety is that the fix does not fully resolve the issue (though it once attempted to do that).

@robinbb robinbb marked this pull request as ready for review April 17, 2026 18:55
@robinbb
Copy link
Copy Markdown
Collaborator Author

robinbb commented Apr 17, 2026

I think you should just bring back your fix and keep the entry. The macos issue is unrelated.

Oh, maybe you mean that I should actually fix the issue in the way that we had before (but which failed on mac). Yes, okay. I will do that in addition to merging this issue, which will make things right in the meantime.

@rgrinberg
Copy link
Copy Markdown
Member

Yes. The failure on mac was just bad luck. I've encountered it today in a different PR, and I'm pretty sure I know the source of the bug (sigwait on macos doesn't work)

@robinbb robinbb merged commit 271bf3c into main Apr 17, 2026
82 of 84 checks passed
@robinbb robinbb deleted the remove-14170-changelog branch April 17, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants