Test for issue #7454: fmt triggers menhir#7455
Merged
emillon merged 3 commits intoocaml:mainfrom Apr 5, 2023
Merged
Conversation
rgrinberg
approved these changes
Mar 30, 2023
Member
rgrinberg
left a comment
rgrinberg
left a comment
There was a problem hiding this comment.
I guess the issue is that we're setting up formatting rules for all sources used for building. We should only be formatting sources that are present in the sources.
Collaborator
|
I wonder if #6585 is related to this. |
Member
Not quite. Dune files always exist in the source (at the moment) |
emillon
approved these changes
Mar 31, 2023
Collaborator
emillon
left a comment
emillon
left a comment
There was a problem hiding this comment.
Sounds good to me too. Please add DCO and I'll rebase+merge.
Signed-off-by: Ulysse Gérard <thevoodoos@gmail.com>
voodoos
force-pushed
the
issue-formatting-generate-menhir-parser
branch
from
29bca00 to
c256209
Compare
Collaborator
Author
Done ! |
Collaborator
|
Can you fix the test so that it uses |
Member
|
None of the uses in this PR require the |
Signed-off-by: Ulysse Gérard <thevoodoos@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #7454.
Expected Behavior
I would expect
dune fmtordune build @fmtto never build anything.(This is an assumption made by OCaml-CI for the
lint-fmtjob. cc @maiste)Actual Behavior
Missing menhir parsers that have a corresponding
.mlifile are generated when callingdune build @fmt