Skip to content

Locally enable ocamlformat#1587

Closed
voodoos wants to merge 3 commits intoocaml:mainfrom
voodoos:ocamlformat-dot-protocol
Closed

Locally enable ocamlformat#1587
voodoos wants to merge 3 commits intoocaml:mainfrom
voodoos:ocamlformat-dot-protocol

Conversation

@voodoos
Copy link
Copy Markdown
Collaborator

@voodoos voodoos commented Mar 29, 2023

This PR add an ocamlformat configuration file and an empty .ocamlformat-enable.

The idea is to progressively format more and more files. When merging PR all changed file should be added to the .ocamlformat-enable file and formatted.

@voodoos voodoos force-pushed the ocamlformat-dot-protocol branch from 14290ab to c6332b1 Compare March 29, 2023 18:51
@voodoos
Copy link
Copy Markdown
Collaborator Author

voodoos commented Mar 30, 2023

Status: investigating the CI issue

  • OCaml-CI doesn't install project deps before running dune build @fmt
  • In Merlin this command does trigger the generation of some files that break because of unmet dependencies

@voodoos
Copy link
Copy Markdown
Collaborator Author

voodoos commented Mar 30, 2023

Found the CI problem. Opened a Dune issue: ocaml/dune#7454

@voodoos voodoos closed this Sep 26, 2024
voodoos added a commit to voodoos/merlin that referenced this pull request Mar 31, 2026
voodoos added a commit to voodoos/merlin that referenced this pull request Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant