Add String.replace_{first,last,all} #14436
Open
+190
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alizter
reviewed
Dec 26, 2025
Alizter
reviewed
Dec 26, 2025
dbuenzli
force-pushed
the
string-replace
branch
from
f0b30e7 to
c8b74ed
Compare
dbuenzli
force-pushed
the
string-replace
branch
from
c8b74ed to
9ae28dc
Compare
nojb
approved these changes
Jan 10, 2026
Contributor
nojb
left a comment
nojb
left a comment
There was a problem hiding this comment.
LGTM
A second core dev approval is needed before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the functions string replacing functions discussed in #14137 it is built (two last commits) on top of the PR of search primitives #14381.