ocamlformat: Add constraints on Dune 3.22

[Julow]

The behavior of the (diff) rules with non-existant files has changed in Dune 3.22, which break OCamlformat's testsuite.

I updated the constraints of all versions of ocamlformat-lib and ocamlformat.0.24.1. Earlier versions of ocamlformat has a upper bound on Dune and later versions depend on ocamlformat-lib.

[Julow]

Related change in Dune: ocaml/dune#13696

[mseri]

This does not work, in the right statement, left is true, so it remains true when not < 3.22

[mseri]

I think the following should work

Suggested change

	"dune" {>= "2.8" & (>= "2.8" | < "3.22" & with-test)}
	"dune" {>= "2.8"}
	"dune" {< "3.22" & with-test}

[Julow]

Thanks!
I got this with the following in Dune:

  (dune
   (or
    (>= 2.8)
    (and
     (< 3.22)
     :with-test)))

Is it wrong too ?

[mseri]

I think you need to add

  (dune
    (and
     (< 3.22)
     :with-test))

In any case, adding dune constraints to the dune file is brittle in my experience. Since dune always adds itself with the appropriate lower bound and since it does not reduce the constraints properly, if often ends up being messy (or wrong like in this case). The only way I can think of right now is be to use a template file.

Otherwise we can add a comment (say in the opam file with a template) to fix it manually on release.

[Julow]

Thanks for your help :) I've lifted the constraints in the dev version so next release won't have the same issue.

[mseri]

In the meantime I suggest we merge this

[Julow]

The issue happens in CI: https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/353fd9234f0397ed1edb6d612e5b9da8472dea1c/variant/compilers,5.4,ocamlformat-lib.0.28.1,revdeps,ocamlformat.0.28.1
for ocamlformat 0.28.1 and 0.29.0. Any idea why ?

[mseri]

It installs ocamlformat-lib without the "with-test" flag, so it picks up dune 3.22, then it re-installs ocamlformat with "with-test" and it seems that at this point it kind of ignores that conflict, but then the call to build dune build -p ocamlformat -j 71 @install @runtest runs all tests and make it fail.

[Julow]

I propagated the change to ocamlformat, let's see!

[Julow]

The issue in the testsuite is gone but there are new errors that I don't understand.

[mseri]

The remaining failures do not depend on this. Thanks!