Merged
Conversation
Collaborator
sergey-tomin
commented
Sep 20, 2019
sergey-tomin
commented
- added DeviceManager class as an intermediary between devices and Optimizer. it is needed to be able to run optimization with virtual devices.
- added logger to some classes. need to catch some strange bug.
- added petra and flash machine interfaces.
- added changes to improve CLI to run a sequence of optimizations.
- added example with a sequence of optimization
… Devices and Optimizer.
Optimizer dev
hhslepicka
suggested changes
Sep 20, 2019
Contributor
hhslepicka
left a comment
hhslepicka
left a comment
There was a problem hiding this comment.
Thank you for the changes Sergey.
I am having a bit of problem understanding why do you need the device manager.
I get the idea of it I am just not sure how you will use it to accomplish what was written at the class docstring.
Let’s schedule a call for some time next week and go over the changes.
…nel was out of limits.
…ious limit condition is the same as current.
… on the stop signal. The delay appears in case the averaging of the target function is used (multiple readings of the target function in a loop).
Optimizer dev
… with browser before the optimizations finishes its work.
Optimizer dev
Contributor
|
TODO before Merging:
|
…ripted optimization and it is not valid for UI optimizations. Renamed at mint.py at self.meta_dev = MetaDevice() to match the new class name MetaDevice.
Collaborator
Author
|
Thanks for remarks. Fixed and ready for merge. Please have a look. |
hhslepicka
approved these changes
Dec 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.