feat(perf): faster plugin-update #610
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdonnalley
requested changes
Sep 5, 2023
| import {ux, Interfaces} from '@oclif/core' | ||
| import spawn from 'cross-spawn' | ||
| import * as fs from 'fs-extra' | ||
| import {spawn} from 'child_process' |
Contributor
There was a problem hiding this comment.
Have you tested this on windows? I tried to use spawn inside of plugins install instead of fork and ran into a host of issues on windows. I ended up abandoning the effort and left fork.
Member
Author
There was a problem hiding this comment.
no, I hadn't tried it on windows. good QA catch!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reuires node 16
use native spawn
use mostly native fs (fs-extra is still around but lazy-loaded only when needed)
chalk instead of oclif/color