Version 1.0.0+: Dependencies injected in lazy-loaded modules break page

[pixelbucket-dev]

This functionality worked before with v0.5.0. Unfortunately with the new versions it breaks.

In our project we are using packs that are loaded through a configuration json. This json defines the main plugins that are required for the pack. It works like a single application, which can be completely different with another configuration, hence other loaded plugins.

Those plugins have to be loaded by ocLazyLoad, which happens in ui-router like this:

$ocLazyLoad.load(pluginsToLoad, {
    serie: true
})...

In some of the plug-ins we added dependencies like this:

angular.module('angularProject.module1', [{
    name: 'plugin1',
    files: [
        'plugin1.module.js',
        'plugin1.model.js',
        'plugin1.controller.js',
        'plugin1.directive.js',
    ],
    serie: true
}]);

Those modules may have dependencies set themselves. This creates a dependency chain.
However, now with ocLazyLoad 1.0.0+ this mechanism doesn't work anymore, despite mentioned in the readme.
There are a lot of errors which change randomly every page load, e.g.:

[$injector:nomod] Module '[...]' is not available! You either misspelled the module name or forgot to load it. If registering a module ensure that you specify the dependencies as the second argument.

or

Error: no file to load has been found, if you're trying to load an existing module you should use the 'inject' method instead of 'load'.

To resolve this problem we have remove those dependency references from the modules and prepare the dependencies manually for each pack (in the pack's configuration json) in the right order for ozLazLoad to register them. This is obviously cumbersome and wastes a lot of time. I have no idea why the mechanism suddenly breaks.

Are we using ocLL wrong with chained dependencies?

[ocombe]

Hmm I think that it's probably my fault, I made a change in the code to avoid the case where some errors would not be rejected but obviously it was working in some cases.
Is there any chance that you could make me a minimal use case (on plnkr or something similar) to reproduce this problem please?

[pixelbucket-dev]

Hi, thanks for the reply.

I've tried to setup a plnkr:
http://plnkr.co/edit/6iQJRQLscDzDiArXJzy9

Unfortunately, there is an error initialising ocLL:

Refused to execute script from 'https://raw.githubusercontent.com/ocombe/ocLazyLoad/1.0.1/dist/ocLazyLoad.js' because its MIME type ('text/plain') is not executable, and strict MIME type checking is enabled.
angular.js:4361 Uncaught Error: [$injector:modulerr] Failed to instantiate module InjectorTest due to:
Error: [$injector:modulerr] Failed to instantiate module oc.lazyLoad due to:
Error: [$injector:nomod] Module 'oc.lazyLoad' is not available! You either misspelled the module name or forgot to load it. If registering a module ensure that you specify the dependencies as the second argument.

Do you have any idea why this doesn't work at all in plnkr? The MIME type bit is very weird.

Thanks for your help.

[ocombe]

I think that I just fixed this issue with release 1.0.3, could you test if it works for you now ?

[pixelbucket-dev]

Hi ocombe, thanks for your hard work. I cannot easily reproduce the old setup we used. Anyway, we had to move one and work out something that will work in future setups. The new configuration involves requirejs with a bit oclazyload ($ocLazyLoad.inject) and it works great. Keep up the good work.