fix(css-loader): ensure CSS loader uses loading patch for PhantomJS 1.9#280
Merged
ocombe merged 1 commit intoocombe:masterfrom Feb 2, 2016
Merged
Conversation
booleanbetrayal
force-pushed
the
fix_phantom19_readystate
branch
from
e393504 to
54d68e9
Compare
Contributor
Author
|
Had a stale fork. I just rebased against upstream master to fix a conflict. |
Owner
|
Good catch, thanks :) |
ocombe
added a commit
that referenced
this pull request
Feb 2, 2016
fix(css-loader): ensure CSS loader uses loading patch for PhantomJS 1.9
Owner
|
I just released 1.1.0 with this, I think I did it right, I haven't published a new version on this repo for ages, let me know if it works |
Contributor
Author
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @ocombe - Noticed today while trying to get PhantomCSS (which relies on Phantom 1.9.x) setup for our single page app, that the CSS loader promises never completed. Seems like Phantom 1.9.x is also subject to the same
readystatechange/ event loading issues that other WebKit variants suffer from. This fixes that!