Skip to content

Bckends: GLFW: Clear emscripten's mousewheel callback before shutdown#6790

Closed
halx99 wants to merge 1 commit intoocornut:masterfrom
halx99:patch-1
Closed

Bckends: GLFW: Clear emscripten's mousewheel callback before shutdown#6790
halx99 wants to merge 1 commit intoocornut:masterfrom
halx99:patch-1

Conversation

@halx99
Copy link
Copy Markdown
Contributor

@halx99 halx99 commented Sep 6, 2023

Version/Branch of Dear ImGui:

Version: v1.89.8-docking

reproduce demo without this patch:
https://axmol.dev/wasm/cpp-tests/cpp-tests
step:

  1. open 2.ImGui
  2. Goback to main manu page
  3. Scroll mouse whell, will see javascript exception on console

@ocornut ocornut changed the title [Backend][GLFW]: Clear mosewheel callback before shutdown Backends: GLFW: Clear MouseWheel Emscripten callback before shutdown Sep 6, 2023
@halx99 halx99 changed the title Backends: GLFW: Clear MouseWheel Emscripten callback before shutdown Bckends: GLFW: Clear mosewheel callback before shutdown Sep 6, 2023
@ocornut ocornut added web emscripten, wgpu etc. and removed ime labels Sep 6, 2023
@ocornut
Copy link
Copy Markdown
Owner

ocornut commented Sep 6, 2023

Thank you for this.
Moved the code in right location and pushed as 56a7b8b

@ocornut ocornut closed this Sep 6, 2023
@ocornut ocornut changed the title Bckends: GLFW: Clear mosewheel callback before shutdown Bckends: GLFW: Clear emscripten's mousewheel callback before shutdown Sep 6, 2023
halx99 added a commit to axmolengine/axmol that referenced this pull request Sep 6, 2023
@halx99 halx99 deleted the patch-1 branch September 10, 2023 03:31
Repository owner deleted a comment from TST539996 Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backends web emscripten, wgpu etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants