Conversation
dvdherron
commented
Dec 9, 2022
dvdherron
commented
This updates most tests for the currently-implemented chunk of the Color 4 feature. A few tests that need more thorough reworking (such as being moved out of `error/` for things that are no longer intended to be errors) are marked as "todo" instead. See sass#1828 See sass/sass#2831
dvdherron
commented
Feb 1, 2023
|
|
||
| <===> weighted_with_space/max/output.css | ||
| a { | ||
| b: rgb(21.268106465009446% -6.688269881046738% 3.5872334279465443%); |
Author
There was a problem hiding this comment.
When an interpolation space is used in this function, should the result still be in the original color's color space?
| - libsass | ||
|
|
||
| <===> error/invalid_method/input.scss | ||
| a {b: invert(turquoise, $space: display-p3)} |
Author
There was a problem hiding this comment.
display-P3 is not listed as one of the valid color interpolation methods. Should this error?
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.