[IMP] Inventory: Bringing product type current#16523
Conversation
|
|
theRealThagomizer
left a comment
theRealThagomizer
left a comment
There was a problem hiding this comment.
Looks good, @erjer-odoo! I had a few stylistic notes that you can implement or ignore, and a few list formatting things. This is ready to move forward!
| If a resale clothing shop buys discounted denim jackets and sells them at a higher cost to the end | ||
| consumer, the `Jacket` product form might have *both* the :guilabel:`Sales` and | ||
| :guilabel:`Purchase` checkboxes selected. |
There was a problem hiding this comment.
A very fussy sort of comment, but maybe this could be less speculative since it's an example? We can just proclaim that this theoretical world is so for the purposes of this example.
| - :guilabel:`Goods`: a tangible, material object (e.g., anything from a hamburger to a house) | ||
| - :guilabel:`Service`: an intangible, immaterial offering (e.g., a repair, a haircut, call center | ||
| assistance) | ||
| - :guilabel:`Combo`: any mix of goods and services (e.g. a new car (*good*) with an oil change | ||
| - :guilabel:`Combo`: any mix of goods and services (e.g., a new car (*good*) with an oil change |
There was a problem hiding this comment.
| - :guilabel:`Goods`: a tangible, material object (e.g., anything from a hamburger to a house) | |
| - :guilabel:`Service`: an intangible, immaterial offering (e.g., a repair, a haircut, call center | |
| assistance) | |
| - :guilabel:`Combo`: any mix of goods and services (e.g. a new car (*good*) with an oil change | |
| - :guilabel:`Combo`: any mix of goods and services (e.g., a new car (*good*) with an oil change | |
| - :guilabel:`Goods`: Tangible, material objects (e.g., anything from a hamburger to a house) | |
| - :guilabel:`Service`: Intangible, immaterial offerings (e.g., a repair, a haircut, call center | |
| assistance) | |
| - :guilabel:`Combo`: Any mix of goods and services (e.g., a new car (*good*) with an oil change |
There was a problem hiding this comment.
I will be accepting this change, but changing the capitalization of what comes after the colon. According to our style guide, if it's a fragment, we do not capitalize the first letter after the colon.
| inventory after all orders are taken into account. In other words, | ||
| :math:`\text{forecasted} = \text{on hand quantity} + \text{incoming shipments} - \text{outgoing shipments}`. |
There was a problem hiding this comment.
Is it worth moving the math text here into an admonition block? I feel like it looks a little strange on the page appearing in-line, but this is just a preference thing.
3 participants
This started out initially as a small fix to make sure two links were showing up on two separate lines, but it expanded to be sure that the page was current with 19.0 changes. I also made changes to language to make things clearer where possible, and screenshots were also updated.
This 19.0 PR can be FWP up to master.