feat(dependency): increase minimum version of setuptools-scm dependency#90
feat(dependency): increase minimum version of setuptools-scm dependency#90ofek merged 1 commit intoofek:masterfrom
Conversation
Increase the minimum version for setuptools-scm. This helps consumers of hatch-vcs to test their package with the minimum suported versions of dependencies. Earlier versions of setuptools-scm did depend on setuptools without a version specifier. Using a tool that allows you to install the earliest supported version of every packages ends up installing setuptools 0.x which would fail of course. Starting with setuptools-scm 8.2.0, the minimum version is 60 something.
There was a problem hiding this comment.
Hello @do3cc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request increases the minimum version of the setuptools-scm dependency from 6.4.0 to 8.2.0 in the pyproject.toml file. The stated intent is to help consumers of hatch-vcs test their packages with the minimum supported versions of dependencies. Older versions of setuptools-scm had issues with setuptools versioning, which this change aims to resolve.
Highlights
- Dependency Update: The minimum version of
setuptools-scmhas been increased to 8.2.0. - Testing Support: This change helps users test their packages against the minimum supported dependency versions.
Changelog
- pyproject.toml
- Increased the minimum version of
setuptools-scmfrom 6.4.0 to 8.2.0.
- Increased the minimum version of
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A version bump, a simple tweak,
To keep the builds from going bleak.
With setuptools-scm now in line,
Our dependency tree will surely shine.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request increases the minimum version of the setuptools-scm dependency. This is a good change as it ensures compatibility with newer versions and avoids issues with older, unsupported versions of setuptools.
Merge Readiness
The pull request is straightforward and addresses a specific dependency issue. The change is well-justified in the description. I am unable to directly approve the pull request, and users should have others review and approve this code before merging. I recommend merging this pull request.
Increase the minimum version for setuptools-scm.
This helps consumers of hatch-vcs to test their package with the minimum suported versions of dependencies.
Earlier versions of setuptools-scm did depend on setuptools without a version specifier. Using a tool that allows you to install the earliest supported version of every packages ends up installing setuptools 0.x which would fail of course.
Starting with setuptools-scm 8.2.0, the minimum version is 60 something.