Reduce ITP with number of active tests per user#1747
Merged
ppigazzini merged 1 commit intoofficial-stockfish:masterfrom Jul 12, 2023
Merged
Reduce ITP with number of active tests per user#1747ppigazzini merged 1 commit intoofficial-stockfish:masterfrom
ppigazzini merged 1 commit intoofficial-stockfish:masterfrom
Conversation
given some excessive number of active tests by some users, this patch reduces itp based on the number of active tests. The formula used is `itp *= 36.0 / (36.0 + count * count)` This reduces slowly the itp for a number of tests smaller than 6, and rapidly afterwards. For 3 active tests, the itp is 80%, for 6 active tests, the itp is 50%, for 15 active tests it is down to 13%. For a maximum share of fishtest... have 6 tests in queue.
Collaborator
|
DEV updated. |
Collaborator
Member
Author
|
The precise numbers might need some time to establish, i.e. once the itp has been recomputed. With 9 tests, it should be around 30% |
Member
Author
Collaborator
|
I updated the previous post, now the ITPs seem to be correct. |
|
I have a question, can we regard tests already set to lower throughput such as 50% as something like 0.5 tests |
Member
Author
|
no, not easily. To transfer throughput, one should be able to pause the others (i.e. use prio -1) |
Member
Author
|
I think this is working as intended |
Collaborator
|
PROD updated, thank you @vondele :) ps: nitpicking, 36.0 was mandatory in python2 |
XInTheDark
added a commit
to XInTheDark/fishtest
that referenced
this pull request
Oct 8, 2023
This distributes the number of cores more fairly between users, and allows for an effective way to transfer/split TP between runs. (See official-stockfish#1747 (comment))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



given some excessive number of active tests by some users, this patch reduces itp based on the number of active tests.
The formula used is
itp *= 36.0 / (36.0 + count * count)This reduces slowly the itp for a number of tests smaller than 6, and rapidly afterwards. For 3 active tests, the itp is 80%, for 6 active tests, the itp is 50%, for 15 active tests it is down to 13%.
For a maximum share of fishtest... have 6 tests in queue.