feat(oneOf,anyOf): explicit discriminator mapping when >1 key/type #1465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvatic
commented
May 25, 2025
This also adds support for explicit discriminator mapping in anyOf and fixes JSON encoding for non-explicit mappings when explicit mappings are present.
jvatic
force-pushed
the
discriminator_mapping
branch
from
0419fd3 to
cdb3dd4
Compare
ghost
approved these changes
May 26, 2025
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This also results in a change in ordering of some variants for the generated encode/decode methods. Logic for each variant is now defined in the same order as the consts. The only downside I see is the unnecessary diffs which seems an acceptable trade-off to adding more complexity to preserve the original ordering.
Fixes #980
Refs #491