Skip to content

Conversation

@sashamelentyev
Copy link
Contributor

Add min/max length for object type

6.4.18 Schema Object -> https://spec.openapis.org/oas/v3.0.0.html#schema-object

And this case have in zoom openapi https://developers.zoom.us/docs/api/

@ernado
Copy link
Member

ernado commented Sep 18, 2025

Should we add actual validation for this?

@sashamelentyev
Copy link
Contributor Author

Yes, because when I try gen client by zoom openapi I got error about min/maxLength.
I add test for this

Signed-off-by: Sasha Melentyev <[email protected]>
@sashamelentyev
Copy link
Contributor Author

I added test for this case.
If need - i can add zoom spec and generate client for example

@ernado
Copy link
Member

ernado commented Sep 19, 2025

Zoom spec would be good.

Yes, because when I try gen client by zoom openapi I got error about min/maxLength.
I add test for this

No, I mean we should add actuall validation, not just allow schema to compile.
We should generate this check, probably with jx Capture.

@ernado ernado merged commit b251253 into ogen-go:main Sep 22, 2025
15 checks passed
@sashamelentyev sashamelentyev deleted the add-len-for-obj branch September 22, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants