Support Chinese time (follows up #30)#39
Merged
olebedev merged 3 commits intoolebedev:masterfrom Jun 13, 2023
Merged
Conversation
RexSkz
changed the title
olebedev
approved these changes
Jun 11, 2023
Owner
olebedev
left a comment
olebedev
left a comment
There was a problem hiding this comment.
LGTM 👍
However, I can't reason about the Chinese language correctness here, would you be willing to add yourself as an owner of this set of rules, like:
diff --git a/CODEOWNERS b/CODEOWNERS
new file mode 100644
index 0000000..778dbbf
--- /dev/null
+++ b/CODEOWNERS
@@ -0,0 +1,3 @@
+* @olebedev
+/rules/zh/ @RexSkz
+
Collaborator
Author
|
Sure! |
Owner
@RexSkz, awesome! Let me know then the patch above is applied, I’ll merge the PR straight after. Best, |
Collaborator
Author
|
@olebedev Patch applied, please have a look~ |
Owner
|
Hey @RexSkz, thanks for that. I am adding you as collaborator to the repository as long as you now own the Chinese language version. |
Collaborator
Author
|
I'm glad to help :) |
|
That's awesome, someone actually fixed the test after half a year! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows up #30 with some extra Chinese phrases added.
The first commit is the rebase, and the next commit is mine.