Skip to content

Request with Content-Length instead of Transfer-Encoding chunked#1441

Open
olivier4576 wants to merge 1 commit intoolivere:release-branch.v7from
olivier4576:olivier4576-content-length
Open

Request with Content-Length instead of Transfer-Encoding chunked#1441
olivier4576 wants to merge 1 commit intoolivere:release-branch.v7from
olivier4576:olivier4576-content-length

Conversation

@olivier4576
Copy link

@olivier4576 olivier4576 commented Dec 2, 2020

Request with Content-Length instead of Transfer-Encoding chunked

@chrisharrisonkiwi
Copy link

chrisharrisonkiwi commented Dec 18, 2020 •
edited
Loading

Oh my gosh, I'm so glad this is coming.
So many headaches over Docker when it tries to hit an ElasticSearch instance using TransferEncoding: Chunked.

@olivere
Copy link
Owner

olivere commented Dec 18, 2020

@chrisharrisonkiwi I'm always interested in the kinds of problems people face out there: What kind of problem do you see with chunked encoding?

@chrisharrisonkiwi
Copy link

chrisharrisonkiwi commented Dec 20, 2020 •
edited
Loading

@chrisharrisonkiwi I'm always interested in the kinds of problems people face out there: What kind of problem do you see with chunked encoding?

Mostly local development issues using ElasticSearch with "localstack".
Detail: I've been using Wireshark to capture requests from within docker containers made by this library and noticed the transfer encoding approach being used.
If I replay the request from within Docker and replace the chunked encoding for a Content-Length it seems to have a lot more luck networking between local services for some reason.

Attempting: "Transfer-Encoding: chunked" in a localstack Docker environment results in:
<!doctype html>
<title>408 Request Timeout</title>
<h1>Request Timeout</h1>
Request timed out; try again later

It could be unrelated, but it certainly seems to help.

@olivier4576
Copy link
Author

olivier4576 commented Aug 19, 2021

Resolves issue #1526

@olivere olivere mentioned this pull request Jan 7, 2022
Open
olivere added a commit that referenced this pull request Jan 7, 2022
@olivere
Experiment with Content-Length
cbb10cd 
This commit experiments with different encodings for the HTTP request
body.

See #1526
See #1441 (PR)
@olivier4576
Update request.go
f10afc5 
Request with ContentLength instead of Transfer-Encoding chunked
@olivier4576 olivier4576 force-pushed the olivier4576-content-length branch from a49e4fb to f10afc5 Compare September 8, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@olivier4576 @chrisharrisonkiwi @olivere