Fix file upload filenames not being set, allow setting MIME type#62
Merged
Conversation
olsh
requested changes
Jan 29, 2025
Owner
|
Thank you for the contribution. |
|
Owner
|
Well, after some thinking, it seems like we should refactor existing files uploading instead of implementing a new method. todoist-net/src/Todoist.Net/TodoistRestClient.cs Lines 119 to 139 in 8f36074 But we need to improve it a bit.
|
…pload-file-metadata # Conflicts: # src/Todoist.Net/Todoist.Net.csproj
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This fixes uploaded files not getting the correct file_name set, and allows setting the MIME type (so that e.g. image thumbnails are generated as appropriate).