confusing update to globals in the flask integration

[RonnyPfannschmidt]

at first sight it does not seem to serve a purpose
edit
https://github.com/omab/python-social-auth/blob/master/social/apps/flask_app/models.py#L88

[omab]

@RonnyPfannschmidt, at first glance it doesn't, but that's what allows you to do from social.apps.flask_app.models import UserSocialAuth in your project (after init_social() was called of course).

[RonnyPfannschmidt]

but that is an project-specific object - that will get stored inside the project if used proper, why have such an hack in addition

[omab]

@RonnyPfannschmidt, FlaskStorage is needed to be on some import path since it's used by the strategy, you can see how the default value is used https://github.com/omab/python-social-auth/blob/master/social/apps/flask_app/utils.py#L10, there's no need to have the others classes since they are accessible through FlaskStorage, I'm willing to remove those from globals().

I'm not comfortable with this solution, having that init_social() looks awful IMO and I really like to get rid of that.

[RonnyPfannschmidt]

if you have a function that takes the app anyway, it can just do a setdefault on the app with the real objects, no need for the funky default schemes

[omab]

Code was improved, seems that this can be closed now.