get_user_id refers to details

[empty]

The method get_user_id refers to details here:

https://github.com/omab/python-social-auth/blob/master/social/backends/base.py#L121

Yet it's looking up the value in response. This is causing an issue for us on Tumblr.

Is the docs incorrect or is the code incorrect?

Michael

[omab]

Docstrings were wrong, which is the issue with tumblr?

[empty]

Well with Tumblr the "username" is not in the response it's only in the details. So the "username" is always None. Tumblr calls it "name" and it's in the "response" of response.

[omab]

@empty, please review the fix and close the ticket if that's OK. Thanks for the report!

[empty]

@omab Sorry for not getting back to you. That actually will not fix the problem. I tried that at first. The issue is not the wrong key but the wrong thing being inspected. I had to subclass the Tumblr and do the following. Hopefully this will explain the issue:

from social.backends.tumblr import TumblrOAuth

class TumblrBackend(TumblrOAuth):

    def get_user_id(self, details, response):
        """Must return a unique ID from values returned on details"""
        return details.get(self.ID_KEY)

[omab]

@empty, actually using response there is the correct value since details is a refined value from response with basic user data to create the instance later, ID_KEY is not expected on that value. Could you share the response value for tumblr?

[empty]

@omab Yeah this will help explain it:

(Pdb) response
{'access_token': {u'oauth_token_secret': u'nFJVzLUBsOdFag6FlHi9oqI47s4lzEMER2fukWXnLvHVoZRNnT', u'oauth_token': u'yywZWdPrYqOQmLOMjvJgX0pRfz4nlNKkuKqK16BIXZfoVbcGbU'}, u'meta': {u'status': 200, u'msg': u'OK'}, u'response': {u'user': {u'following': 0, u'blogs': [{u'updated': 1389913770, u'description': u'', u'drafts': 0, u'title': u'Untitled', u'url': u'http://mtriereldarion.tumblr.com/', u'messages': 0, u'tweet': u'N', u'share_likes': True, u'posts': 13, u'primary': True, u'queue': 0, u'admin': True, u'followers': 0, u'ask': False, u'facebook': u'N', u'type': u'public', u'facebook_opengraph_enabled': u'N', u'name': u'mtriereldarion'}], u'default_post_format': u'html', u'name': u'mtriereldarion', u'likes': 10}}}
(Pdb) response.keys()
['access_token', u'meta', u'response']
(Pdb) response["name"]
*** KeyError: 'name'
(Pdb) response["response"]["user"]["name"]
u'mtriereldarion'
(Pdb) details
{'username': u'mtriereldarion', 'fullname': u'Untitled'}

[omab]

@empty, with 9d45d50 looks better?

[omab]

Looks fixed, I'll close the issue, reopen if needed.