Skip to content

Unavailable facebook raises unexpected ConnectionError #155

@ziima

Description

@ziima

If facebook happen to be unavailable from python social I would expect one of the social exceptions to be raised. Instead ConnectionError pops unhandled.

This probably applies for all OAuth backends. Used master-ish version of python social.

File "/usr/lib/python2.7/dist-packages/social/actions.py", line 44, in do_complete
  *args, **kwargs)

File "/usr/lib/python2.7/dist-packages/social/strategies/base.py", line 67, in complete
  return self.backend.auth_complete(*args, **kwargs)

File "/usr/lib/python2.7/dist-packages/social/backends/facebook.py", line 61, in auth_complete
  'code': self.data['code']

File "/usr/lib/python2.7/dist-packages/social/backends/base.py", line 194, in get_querystring
  return parse_qs(self.request(url, *args, **kwargs).text)

File "/usr/lib/python2.7/dist-packages/social/backends/base.py", line 186, in request
  response = request(method, url, *args, **kwargs)

File "/usr/lib/python2.7/dist-packages/requests/api.py", line 44, in request
  return session.request(method=method, url=url, **kwargs)

File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 279, in request
  resp = self.send(prep, stream=stream, timeout=timeout, verify=verify, cert=cert, proxies=proxies)

File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 374, in send
  r = adapter.send(request, **kwargs)

File "/usr/lib/python2.7/dist-packages/requests/adapters.py", line 206, in send
  raise ConnectionError(sockerr)

ConnectionError: [Errno 110] Connection timed out

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions