On new Tumblr login: AttributeError: 'NoneType' object has no attribute 'expiration_datetime'

[tklovett]

When I try to log in as a completely new Tumblr user with no existing account, I get the error in the title. I'm using social.apps.django_app.default and django.contrib.auth for my auth, nothing custom. An Auth.User object is created successfully, but not a Default.User Social Auth object.

In the function where the error occurs, user.social_user (and therefor social_user) is None. Which is why social_user.expiration_datetime() raises an uncaught exception.

Any idea what's going on?

Traceback (most recent call last):
  File "/Users/tklovett/.virtualenvs/telescope/lib/python2.7/site-packages/django/contrib/staticfiles/handlers.py", line 67, in __call__
    return self.application(environ, start_response)
  File "/Users/tklovett/.virtualenvs/telescope/lib/python2.7/site-packages/dj_static.py", line 59, in __call__
    return self.application(environ, start_response)
  File "/Users/tklovett/.virtualenvs/telescope/lib/python2.7/site-packages/django/core/handlers/wsgi.py", line 206, in __call__
    response = self.get_response(request)
  File "/Users/tklovett/.virtualenvs/telescope/lib/python2.7/site-packages/django/core/handlers/base.py", line 196, in get_response
    response = self.handle_uncaught_exception(request, resolver, sys.exc_info())
  File "/Users/tklovett/.virtualenvs/telescope/lib/python2.7/site-packages/django/core/handlers/base.py", line 231, in handle_uncaught_exception
    return debug.technical_500_response(request, *exc_info)
  File "/Users/tklovett/.virtualenvs/telescope/lib/python2.7/site-packages/django_extensions/management/technical_response.py", line 5, in null_technical_500_response
    six.reraise(exc_type, exc_value, tb)
  File "/Users/tklovett/.virtualenvs/telescope/lib/python2.7/site-packages/django/core/handlers/base.py", line 114, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/Users/tklovett/.virtualenvs/telescope/lib/python2.7/site-packages/django/views/decorators/csrf.py", line 57, in wrapped_view
    return view_func(*args, **kwargs)
  File "/Users/tklovett/.virtualenvs/telescope/lib/python2.7/site-packages/social/apps/django_app/utils.py", line 45, in wrapper
    return func(request, backend, *args, **kwargs)
  File "/Users/tklovett/.virtualenvs/telescope/lib/python2.7/site-packages/social/apps/django_app/views.py", line 21, in complete
    redirect_name=REDIRECT_FIELD_NAME, *args, **kwargs)
  File "/Users/tklovett/.virtualenvs/telescope/lib/python2.7/site-packages/social/actions.py", line 72, in do_complete
    login(strategy, user)
  File "/Users/tklovett/.virtualenvs/telescope/lib/python2.7/site-packages/social/apps/django_app/views.py", line 44, in _do_login
    expiration = social_user.expiration_datetime()
AttributeError: 'NoneType' object has no attribute 'expiration_datetime'

[omab]

Which Django version?

[tklovett]

1.6.1

Django==1.6.1
MySQL-python==1.2.5
PyTumblr==0.0.5
Werkzeug==0.9.4
distribute==0.6.49
dj-database-url==0.2.2
dj-static==0.0.5
django-extensions==1.3.2
django-forms-bootstrap==2.0.3.post2
django-jsonfield==0.9.12
django-nose==1.2
django-stripe-payments==2.0b32
django-toolbelt==0.0.1
gunicorn==18.0
httplib2==0.8
mock==1.0.1
nose==1.3.0
oauth2==1.5.211
oauthlib==0.6.0
psycopg2==2.5.2
python-openid==2.2.5
python-social-auth==0.1.17
requests==2.1.0
requests-oauthlib==0.4.0
six==1.5.2
static==0.4
stevedore==0.13
stripe==1.11.0
virtualenv==1.10.1
virtualenv-clone==0.2.4
virtualenvwrapper==4.1.1
wsgiref==0.1.2

[tobiasbartel]

Something similar happens to me, but i am logged in at my django app and at tumblr.
I get this error:

Environment:


Request Method: GET

Django Version: 1.6.1
Python Version: 2.7.3
Installed Applications:
('django.contrib.admin',
 'django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.sessions',
 'django.contrib.messages',
 'django.contrib.staticfiles',
 'django.contrib.admin',
 'south',
 'social.apps.django_app.default',
 'bootstrap3',
 'FeaturedProducts',
 'tweets',
 'webUI')
Installed Middleware:
('django.contrib.sessions.middleware.SessionMiddleware',
 'django.middleware.common.CommonMiddleware',
 'django.middleware.csrf.CsrfViewMiddleware',
 'social.apps.django_app.middleware.SocialAuthExceptionMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'django.contrib.messages.middleware.MessageMiddleware',
 'django.middleware.clickjacking.XFrameOptionsMiddleware')


Traceback:
File "/home/angeber/lib/python2.7/django/core/handlers/base.py" in get_response
  114.                     response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/home/angeber/lib/python2.7/social/apps/django_app/utils.py" in wrapper
  45.             return func(request, backend, *args, **kwargs)
File "/home/angeber/lib/python2.7/social/apps/django_app/views.py" in auth
  12.     return do_auth(request.social_strategy, redirect_name=REDIRECT_FIELD_NAME)
File "/home/angeber/lib/python2.7/social/actions.py" in do_auth
  25.     return strategy.start()
File "/home/angeber/lib/python2.7/social/strategies/base.py" in start
  62.             return self.redirect(self.backend.auth_url())
File "/home/angeber/lib/python2.7/social/backends/oauth.py" in auth_url
  97.         token = self.set_unauthorized_token()
File "/home/angeber/lib/python2.7/social/backends/oauth.py" in set_unauthorized_token
  154.         token = self.unauthorized_token()
File "/home/angeber/lib/python2.7/social/backends/oauth.py" in unauthorized_token
  174.         return response.content.decode(response.encoding)

Exception Type: TypeError at /login/tumblr/
Exception Value: decode() argument 1 must be string, not None

[omab]

@tobiasbartel, not the same issue, yours look like #173 which is solved.

[tklovett]

@omab any idea what's causing my issue? I'm happy to PM you any info you need.

[mionch]

I am having the exact same problem when logging in with a new Facebook user - user.social_user is None. Maybe this may be of any help - I managed to temporarily get it working by disabling the SOCIAL_AUTH_USER_MODEL setting, as I am trying to use it to redirect the model to my own subclass of django.contrib.auth.models.User. I am running version 0.1.20 on Django 1.6.

[mionch]

Ok, it seems the fault was on my side - my custom model defined a field 'user_id', which was sometimes taken as the id field of default django User class.

Anyway, @tklovett, hope what I found through debugging may help you - the error itself was caused by an IntegrityError at the point of creating an instance of SocialUser in method associate_user at social.pipelines.social_auth.py. The error concerned a duplicate private key consisting of the uid and auth provider - in my case a social user with my Facebook ID was created before but possibly due to an error, was not brought to the end of auth pipeline. If you have any questions, PM me - I'll be happy to help with the issue.

[tklovett]

Hey @mionch, I'd like to take you up on your offer to help. What's the best way to reach you?

[tklovett]

Possibly related:
get_user_id() in backends/base.py is returning None

In get_user_id(self, details, response):, the value for response is:

{
    'access_token': {u'oauth_token_secret': u'XXX', u'oauth_token': u'XXX'},
   u'meta': {u'status': 200, u'msg': u'OK'},
   u'response': {u'user': {u'following': 1, u'blogs': [{u'updated': 0, u'description': u'test', u'drafts': 0, u'title': u'test', u'url': u'http://tklovett-test.tumblr.com/', u'messages': 0, u'tweet': u'N', u'share_likes': True, u'posts': 0, u'primary': True, u'queue': 0, u'admin': True, u'followers': 0, u'ask': False, u'facebook': u'N', u'type': u'public', u'facebook_opengraph_enabled': u'N', u'name': u'tklovett-test'}], u'default_post_format': u'html', u'name': u'tklovett-test', u'likes': 0}}
}

And self.ID_KEY = 'username', so response.get(self.ID_KEY) is None.

Then I get the same IntegrityError exception as @mionch in associate_user, since 'columns provider, uid are not unique' (tumblr, None)

[tklovett]

Ok I've pinpointed the issue. The first person to ever log in to gets a User object and UserSocialAuth object successfully created. Because of the issue above, the UserSocialAuth.uid is set to 'None'. From that point on, anyone who tries to log in with a different account gets a User object created, but cannot have a UserSocialAuth created because it tries to use the same (provider='tumblr', uid='None') pair for a unique key. When the original user disconnects and re-authenticates with tumblr, it tries to retrieve the UserSocialAuth using None for the uid (not the string 'None'). It then sees an existing User object with that username, and creates a new User object according to the duplicate username rules (So the next time tklovett logs in, user tklovett9365027503 is created).

So the issue arises from this code:

def get_user_id(self, details, response):
        """Must return a unique ID from values returned on details"""
        return response.get(self.ID_KEY)

But I don't know if the tumblr backend is not setting ID_KEY properly, if Tumblr is sending an improperly formatted response, or if the wrong thing is being passed in as the response. @omab, do you know?

[mionch]

Well, I've been looking through the code right now and the outcome causing the error seems to be exactly the same as in my case. But speaking of the cause, in my case the backend for Tumblr seems to look like this:

class TumblrOAuth(BaseOAuth1):
    name = 'tumblr'
    ID_KEY = 'name'
    (...)

So, from what you wrote, the uid should be extracted from the name field, which is present in your request... It seems strange to me that on your side this setting is set to 'username'. Maybe you should try editing this field in the tumblr backend just to see if it solves the issue?

[mionch]

Oh, I think I found what might be addressing the issue, which seems to be already fixed. I've looked at the history of the the Tumblr backend file and it seems that on January 17th @omab introduced a fix (9d45d50) that looks like a workaround for the get_user_id method in this backend. What is more, wrong ID_KEY was also fixed before (87a4943).

[tklovett]

I was working with python-social-auth==0.1.17, I believe. I've updated now to 0.1.20, I'll see if that fixes.

[mionch]

It is exactly the version I use, so it appears it still lacks the other fix with overriding the method - it is not present in my code. Luckily, it is a small change, so it should be easy to use as a hotfix.

[omab]

@mionch, try installing it using pip install -e git+git@github.com:omab/python-social-auth.git@711b892c94efabf2784157107b7ae5e122b21b12#egg=python_social_auth-master