Django usernames more then 30 charracters, via setting variable

[altryne]

Hi,
I have this problem and I can't find any help.
We struggled with the issue of usernames that are shorter then 30 chars, as we put emails in usernames.
We added a migration step in django, so now everyone who registers through our site, can have a 70 character email/username.

Python social-auth however, takes the "max_length" of username, straight from the ORM, which is 30 characters.

I propose making the max_length configurable, like every other setting in that pipeline.

email_as_username = strategy.setting('USERNAME_IS_FULL_EMAIL', False)
        uuid_length = strategy.setting('UUID_LENGTH', 16)
        max_length = storage.user.username_max_length()
        do_slugify = strategy.setting('SLUGIFY_USERNAMES', False)
        do_clean = strategy.setting('CLEAN_USERNAMES', True)

Will become

email_as_username = strategy.setting('USERNAME_IS_FULL_EMAIL', False)
        uuid_length = strategy.setting('UUID_LENGTH', 16)
        max_length = strategy.setting('USERNAME_MAX_LENGTH',storage.user.username_max_length())
        do_slugify = strategy.setting('SLUGIFY_USERNAMES', False)
        do_clean = strategy.setting('CLEAN_USERNAMES', True)

[omab]

Wouldn't be easier to extend the user model in your project and override the username field? That also has the benefit of forms validation working OK.

[altryne]

It would be easier, if you think about it upfront.
IMHO it seems a shame that literally every other setting there is configurable, but this one is kinda hardcoded

[omab]

Actually this is not hardcoded and it's dynamically loaded from your model definition, the correct solution is to make your model reflect your domain properly.