Added support for django custom user with no 'username' field#10
Merged
omab merged 1 commit intoomab:masterfrom May 21, 2013
jgsogo:master
Merged
Added support for django custom user with no 'username' field#10omab merged 1 commit intoomab:masterfrom jgsogo:master
omab merged 1 commit intoomab:masterfrom
jgsogo:master
Conversation
omab
added a commit
that referenced
this pull request
May 21, 2013
Added support for django custom user with no 'username' field
Owner
|
Thanks for the fix, DSA already has a solution for this issue which I didn't had time to sit and port to PSA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I come accross this issue today while working with a custom user model on django 1.5. Code from psa was failing when there was no field named "username". I think this pull request can solve this issue in a backwards compatible way.
MongoEngine: I've never work with it, don't know if the same changes should be included.
DSA: If you want me to, tomorrow I write the solution also for django-social-auth.
Thanks for your work!