Skip to content

Fix #460: Call force_text on _URL settings to support reverse_lazy with default session serializer #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
omab merged 1 commit into from
Apr 2, 2015
Merged

Fix #460: Call force_text on _URL settings to support reverse_lazy with default session serializer #468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion social/strategies/django_strategy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from django.shortcuts import redirect
from django.template import TemplateDoesNotExist, RequestContext, loader
from django.utils.datastructures import MergeDict
from django.utils.encoding import force_text
from django.utils.translation import get_language

from social.strategies.base import BaseStrategy, BaseTemplateStrategy
Expand All @@ -30,7 +31,10 @@ def __init__(self, storage, request=None, tpl=None):
super(DjangoStrategy, self).__init__(storage, tpl)

def get_setting(self, name):
return getattr(settings, name)
value = getattr(settings, name)
if name.endswith('_URL'):
value = force_text(value)
return value

def request_data(self, merge=True):
if not self.request:
Expand Down