removed @app.teardown_request since it is called before @app.teardown…#690
Merged
omab merged 1 commit intoomab:masterfrom Jul 22, 2015
Merged
removed @app.teardown_request since it is called before @app.teardown…#690omab merged 1 commit intoomab:masterfrom
omab merged 1 commit intoomab:masterfrom
Conversation
…_appcontext and removes current session. With @app.teardown_request session is removed just before session.commit and logged in user can not be saved on db. Added session.rollback in case of error and session remove to remove thread local session storage.
omab
added a commit
that referenced
this pull request
Jul 22, 2015
removed @app.teardown_request since it is called before @app.teardown…
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removed @app.teardown_request since it is called before @app.teardown_appcontext and clears current session.
With @app.teardown_request session is removed just before session.commit and logged in user can not be saved on db.
Added session.rollback in case of error and session remove to remove thread local session storage.