Python 3 support for facebook-app backend#749
Merged
omab merged 1 commit intoomab:masterfrom Oct 5, 2015
mya-systems:master
Merged
Python 3 support for facebook-app backend#749omab merged 1 commit intoomab:masterfrom mya-systems:master
omab merged 1 commit intoomab:masterfrom
mya-systems:master
Conversation
omab
added a commit
that referenced
this pull request
Oct 5, 2015
Python 3 support for facebook-app backend
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses Issue #670. The problem was that unicode strings are default in Python 3, but the base64 and hmac libraries require byte strings. The fix was to explicitly encode and decode the strings as necessary. I tested this patch in Python 2.7.6 and 3.4.0.