Skip to content

Formatter fixes for SAML to support Py2.6#783

Merged
omab merged 1 commit intoomab:masterfrom
matburt:master
Dec 17, 2015
Merged

Formatter fixes for SAML to support Py2.6#783
omab merged 1 commit intoomab:masterfrom
matburt:master

Conversation

@matburt
Copy link
Copy Markdown
Contributor

@matburt matburt commented Nov 11, 2015

This fix allows the SAML Backend to support Python 2.6

@chrismeyersfsu
Copy link
Copy Markdown

👍 works with py2.6 for me.

@tkajtoch
Copy link
Copy Markdown

Clean commit.
Python 2.6 requires the replacement_field to be filled by the field_name.

Docs: https://docs.python.org/2.6/library/string.html#format-string-syntax

@matburt
Copy link
Copy Markdown
Contributor Author

matburt commented Dec 17, 2015

You can use {0} for positional arguments though (which is what is used here)... you just can't use the empty variant {}

@tkajtoch
Copy link
Copy Markdown

@matburt I know. My comment is just some kind of note for @omab to accept this PR quickly :-)

@matburt
Copy link
Copy Markdown
Contributor Author

matburt commented Dec 17, 2015

ah, gotcha!

On Thu, Dec 17, 2015 at 5:01 AM, Tomasz Kajtoch notifications@github.com
wrote:

@matburt https://github.com/matburt I know. My comment is just some
kind of note for @omab https://github.com/omab to accept this PR
quickly :-)


Reply to this email directly or view it on GitHub
#783 (comment)
.

omab added a commit that referenced this pull request Dec 17, 2015
Formatter fixes for SAML to support Py2.6
@omab omab merged commit 43b72de into omab:master Dec 17, 2015
@omab
Copy link
Copy Markdown
Owner

omab commented Dec 17, 2015

Sorry for the delay.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants