BaseOAuth2: Store access token in response if it does not exist#816
Merged
omab merged 1 commit intoomab:masterfrom Mar 28, 2016
kchang:patch-1
Merged
BaseOAuth2: Store access token in response if it does not exist#816omab merged 1 commit intoomab:masterfrom kchang:patch-1
omab merged 1 commit intoomab:masterfrom
kchang:patch-1
Conversation
`BaseOAuth2.do_auth` wasn't storing the access token to be passed to the pipeline. As a result, backends inheriting from `BaseOAuth2` wasn't storing the token because `OAuthAuth.extra_data` never had the token information passed to it.
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BaseOAuth2.do_authwasn't storing the access token to be passed to the pipeline. As a result, backends inheriting fromBaseOAuth2wasn't storing the token becauseOAuthAuth.extra_datanever had the token information passed to it.Reference:
BaseOAuth1.do_authhttps://github.com/omab/python-social-auth/blob/master/social/backends/oauth.py#L185-L193
OAuthAuth.extra_datahttps://github.com/omab/python-social-auth/blob/master/social/backends/oauth.py#L39-L46
Related:
#416