Updates to OpenIdConnectAuth#911
Merged
omab merged 2 commits intoomab:masterfrom Apr 26, 2016
clintonb:oidc-updates
Merged
Conversation
The maximum age of the ID token is now exposed as a class variable rather than hardcoded to 10 minutes.
Contributor
Author
|
@omab please reivew |
Owner
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit adds support for passing kwargs to
jwt.decode(), allowing for great flexibility to determine, for example, which signing algorithms are used or the expected value of the audience claim.The second commit (a) instructs PyJWT to verify the iat claim and ensure a value is present, and (b) makes the value against which the claim is compared configurable. I don't know why I hardcoded this to 10 minutes; but, that is not in the spec, and should be configurable for each individual client.