Skip to content

Allow for server side flow for Google+#92

Merged
omab merged 1 commit intoomab:masterfrom
assiotis:master
Nov 18, 2013
Merged

Allow for server side flow for Google+#92
omab merged 1 commit intoomab:masterfrom
assiotis:master

Conversation

@assiotis
Copy link
Copy Markdown
Contributor

  1. Fix a bug where extra data passed via Google+ were mostly ignored

  2. Enable "offline" mode by taking the additional step to exchange the code for a server-side access token and a refresh token. See https://developers.google.com/+/web/signin/server-side-flow

refresh token that can be subsequently used to perform operations on
behalf of the user, even if the user is not online.

This commit allows for that scenario by exchanging the passed in code
for a server-side access token and a refresh token. The refresh token is
    only granted the first time the user authorized the application
    (unless approvalprompt = force in the JavaScript).

This commit also fixes a bug where the extra data given by Google+ were
ignored
omab added a commit that referenced this pull request Nov 18, 2013
@omab omab merged commit 46ef856 into omab:master Nov 18, 2013
@omab
Copy link
Copy Markdown
Owner

omab commented Nov 18, 2013

Thanks!

@Madd
Copy link
Copy Markdown

Madd commented Mar 26, 2014

Was this broken by this conflict? Can't get it to work...
6bead86

@omab
Copy link
Copy Markdown
Owner

omab commented Mar 26, 2014

The change introduced simplifications to the code that should keep the feature working, do you see anything wrong in the change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants