Refactor path for configuration file, option(s) and Docker image#150
Merged
thakurajayL merged 2 commits intoomec-project:mainfrom Nov 1, 2024
Merged
Conversation
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
gab-arrobo
force-pushed
the
refactor-configuration
branch
from
b9872ab to
d305b21
Compare
thakurajayL
reviewed
Nov 1, 2024
| }) | ||
|
|
||
| srv, err := http2_util.NewServer(":30678", NrfLogPath, router) | ||
| srv, err := http2_util.NewServer(":30678", "/opt/sslkey", router) |
Contributor
There was a problem hiding this comment.
Could you pls point me where /opt/sslkey is updated?
Contributor
Author
There was a problem hiding this comment.
The path is actually not used. This is just a "test" server. That is, the path in this case is irrelevant. If you look into the service/init.go, there you will see that we update the path for the log accordingly (which is set to be the same directory as where the config file is located)
Contributor
Author
There was a problem hiding this comment.
For this NF, here is where we update the path accordingly: https://github.com/omec-project/nrf/pull/150/files#diff-3289814d5eb2b5ebf4f9002fc41f602d2af395ca60676275f6113c0defa8f485R242
thakurajayL
approved these changes
Nov 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.