Skip to content

Improve loop to use range and replace some loops to use copy #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghislainbourgeois merged 1 commit into from
Apr 4, 2025
Merged

Improve loop to use range and replace some loops to use copy #199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 9 additions & 15 deletions context/management_data.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// SPDX-FileCopyrightText: 2025 Intel Corporation
// SPDX-FileCopyrightText: 2021 Open Networking Foundation <info@opennetworking.org>
// Copyright 2019 free5GC.org
//
Expand Down Expand Up @@ -469,7 +470,6 @@ func setUriListByFilter(filter bson.M, uriList *[]string) {
}

func nnrfUriList(originalUL *UriList, UL *UriList, location []string) {
var i int
var b *Links
var flag bool
var c []models.Link
Expand All @@ -478,25 +478,22 @@ func nnrfUriList(originalUL *UriList, UL *UriList, location []string) {
size := len(location) + len(originalUL.Link.Item)

// check duplicate
for i = 0; i < len(originalUL.Link.Item); i++ {
if originalUL.Link.Item[i].Href == location[0] {
for _, item := range originalUL.Link.Item {
if item.Href == location[0] {
flag = false
break
}
}

if flag {
c = make([]models.Link, size)
for i = 0; i < len(originalUL.Link.Item); i++ {
c[i].Href = originalUL.Link.Item[i].Href
}
for i = len(originalUL.Link.Item); i < len(location)+len(originalUL.Link.Item); i++ {
c[i].Href = location[i-len(originalUL.Link.Item)]
copy(c, originalUL.Link.Item)
for i, loc := range location {
c[len(originalUL.Link.Item)+i].Href = loc
}
} else {
c = make([]models.Link, size-1)
for i = 0; i < len(originalUL.Link.Item); i++ {
c[i].Href = originalUL.Link.Item[i].Href
}
copy(c, originalUL.Link.Item)
}

b.Item = c
Expand Down Expand Up @@ -657,12 +654,9 @@ func NnrfUriListLimit(originalUL *UriList, limit int) {
// response limit

if limit < len(originalUL.Link.Item) {
var i int
b := new(Links)
c := make([]models.Link, limit)
for i = 0; i < limit; i++ {
c[i].Href = originalUL.Link.Item[i].Href
}
copy(c, originalUL.Link.Item[:limit])
b.Item = c
originalUL.Link = *b
}
Expand Down