Fix issue with outdated dependency that might create excessive memory allocation#209
Merged
gab-arrobo merged 2 commits intoomec-project:mainfrom May 12, 2025
Conversation
…cation Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an outdated dependency that was causing excessive memory allocation by upgrading the JWT library and modifying the claims structure accordingly. The changes include updating the import from jwt v4 to jwt v5 and replacing StandardClaims with RegisteredClaims in the access token claims.
- Upgrade dependency for improved memory handling.
- Update claims structure to align with the jwt/v5 expectations.
Files not reviewed (2)
- VERSION: Language not supported
- go.mod: Language not supported
Comments suppressed due to low confidence (1)
producer/access_token.go:54
- Ensure that switching from StandardClaims to RegisteredClaims is fully compatible with the expected JWT claims handling in the rest of the system, as jwt/v5 may introduce differences in behavior.
RegisteredClaims: jwt.RegisteredClaims{},
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
thakurajayL
approved these changes
May 12, 2025
gab-arrobo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally create a minor release