Make improvements to DSRM code#204
Merged
gab-arrobo merged 1 commit intoomec-project:mainfrom Oct 27, 2025
Merged
Conversation
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
There was a problem hiding this comment.
Pull Request Overview
This PR improves error handling and code quality in the DSRM (Distributed Shared Resource Manager) module. The changes focus on proper resource cleanup, error handling, and using modern Go idioms.
Key changes:
- Added proper context cancellation to prevent resource leaks
- Replaced panic calls with graceful error handling and logging
- Improved map lookup patterns using the idiomatic two-value form
- Modernized BSON document construction syntax
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| continue | ||
| } | ||
| var s streamDoc | ||
| bsonBytes, _ := bson.Marshal(data) |
There was a problem hiding this comment.
Error from bson.Marshal is being ignored. If marshaling fails, the subsequent Unmarshal will operate on nil/empty bytes and produce misleading errors. Add error handling: bsonBytes, err := bson.Marshal(data); if err != nil { logger.DrsmLog.Errorf(\"failed to marshal stream data: %v\", err); continue }
thakurajayL
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.