Testing: DataScribe module

[jimsafley]

This module should now work with Omeka S version 4+. Refer to the user manual and project website for instructions on how to use DataScribe.

[aviannamiller]

Functionality looks to be all there.

A few small potential bugs (more feedback to come in a separate issue):

• For datasets, where do guidelines end up if they’ve been configured under General? I’m not seeing them output anywhere on the dataset or items.
• On dataset and item pages, the sidebar is obscuring controls:
  
  Here, the filter select and submit button are concealed, so the sidebar needs to collapse before those controls can be interacted with. Main page content is resizing appropriately (width-wise), so this seems to be more of an issue with the browse controls, etc.

[jimsafley]

For datasets, where do guidelines end up if they’ve been configured under General? I’m not seeing them output anywhere on the dataset or items.

On the add/edit record page there's a "Guidelines" button that opens a modal window containing the guidelines markup. I notice that the close window button is invisible on the top right. @kimisgold Can you make it visible?

On dataset and item pages, the sidebar is obscuring controls:

@kimisgold Can you take a look at this?

[aviannamiller]

On the add/edit record page there's a "Guidelines" button that opens a modal window containing the guidelines markup. I notice that the close window button is invisible on the top right. @kimisgold Can you make it visible?

Thank you, I missed that completely. I would also add that keyboard focus is moving behind the modal (to footer content, specifically). That shouldn't be happening.

[kimisgold]

I've fixed the issues with the overlapping controls and Font Awesome glyphs that don't appear. Those are ready for a look. Trapping keyboard focus in the modal will take a little more time.

[kimisgold]

I have a draft of the guidelines modal on the guidelines-modal branch ready for a look.

[aviannamiller]

@kimisgold – Things seem good with the modal, however, I now cannot activate the Guidelines button at all to test it on Safari, either on my older version on desktop or on mobile (which should be a current version).

Otherwise, the previously obscured controls are much improved. I am noticing the number input within #media-pagination on records is obscured on all browsers at viewport zooms 100%+ when a horizontal layout is chosen (and the sidebar is open). Not certain if this was a problem before, but it looks like it may have been.

[kimisgold]

I'm going to work on a fix for the pagination. In the meantime, I've implemented the js solution to managing the dialog toggle. Could you pull and try it again in Safari?

[aviannamiller]

Yes, that fixed it!