Skip to content

feat: notify on runner job activity#68

Open
Peyton-Spencer wants to merge 1 commit intomainfrom
feat/43-job-notifications
Open

feat: notify on runner job activity#68
Peyton-Spencer wants to merge 1 commit intomainfrom
feat/43-job-notifications

Conversation

@Peyton-Spencer
Copy link
Copy Markdown
Contributor

Summary

  • add native macOS job notifications using UserNotifications, with click-through links that open the related GitHub Actions run
  • detect job start/completion from the existing runner status poller by resolving workflow/job metadata from GitHub when a runner flips between idle and busy
  • add a single settings toggle to enable or disable notifications, defaulting to on for existing and new configs

Testing

  • git diff --check
  • swift test (not runnable in this container: swift: command not found)

Notes

  • this keeps v1 intentionally simple with one global notifications toggle instead of separate per-event settings

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 25, 2026

Warning

Rate limit exceeded

@Peyton-Spencer has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 0 minutes and 34 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0a820a45-0642-44ed-bdfe-727f575fb66e

📥 Commits

Reviewing files that changed from the base of the PR and between 28e1c36 and 565d7c8.

📒 Files selected for processing (7)
  • Sources/MacRunner/MacRunnerApp.swift
  • Sources/Models/Runner.swift
  • Sources/Services/GHCLIService.swift
  • Sources/Services/JobNotificationService.swift
  • Sources/Services/RunnerManager.swift
  • Sources/Views/MenuBarView.swift
  • Tests/MacRunnerTests/MacRunnerTests.swift
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/43-job-notifications

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Add native macOS notifications for job start and completion, including click-through links to the GitHub Actions run and a single settings toggle to disable them. Use the existing runner status poller to detect transitions and tie notifications to the workflow/job metadata fetched from GitHub.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Peyton-Spencer Peyton-Spencer force-pushed the feat/43-job-notifications branch from 7185908 to 565d7c8 Compare March 25, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant