FIX: Can't properly filter by nullable primitive datatypes#41
Merged
Conversation
… against a null value threw an exception.
Collaborator
Author
|
@matthewtoghill please have a look at this PR you too if you like 😉 |
Gonzo345
approved these changes
Mar 7, 2023
Contributor
Gonzo345
left a comment
There was a problem hiding this comment.
Thank you so much to @matthewtoghill and @CesarD for this! (づ ̄3 ̄)づ╭❤️~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed #39 by adding validations that include nullable types and also evaluates the underlying type of an eventually nullable value.
It also fixes another scenario where when comparing non-nullable types against a null value it threw an exception.
Related Issue
Fixes #39
Motivation and Context
Fixes a reported bug.
How Has This Been Tested?
Tested different scenarios via Postman directly against the API.
Screenshots (if appropriate):
N/A
Types of changes
Checklist: