Make From param optional in Transaction object#32
Merged
onrik merged 1 commit intoonrik:masterfrom Jul 27, 2022
Merged
Conversation
Contributor
Author
|
@onrik any thoughts on this small PR? Thanks ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In eth_call the
fromfield is optional (unlike for instance in eth_sendTransaction).However, the current code always fills in the
fromfield with an empty string if no actual value is provided, which results in the following error:invalid argument 0: hex string has length 0, want 40 for common.Addresswhen using
eth_callwith nofromfield provided.This fix makes the
fromfield optional so that the rpc json request gets correctly serialized.