Open
Conversation
onrik
reviewed
Jul 27, 2022
| log logger | ||
| Debug bool | ||
| retries int | ||
| retryBackoff int // milliseconds |
Owner
There was a problem hiding this comment.
Why milliseconds? Golang has the type time.Duration
Owner
|
Thanks for PR. But i think this is not responsibility of ethrpc. Retries can be implemented by transaport in custom http client. package main
import (
"fmt"
"log"
"time"
"github.com/onrik/ethrpc"
)
type RetryTransport struct {
transport http.RoundTripper
attempts int
delay time.Duration
}
func (t *RetryTransport) RoundTrip(request *http.Request) (r *http.Response, err error) {
for i := 0; i < t.attempts; i++ {
r, err = t.transport.RoundTrip(request)
if err != nil {
time.Sleep(t.delay)
continue
}
}
return
}
func main() {
client := ethrpc.New("http://127.0.0.1:8545", WithHttpClient(&http.Client{
Transport: &RetryTransport{
transport: http.DefaultTransport,
attempts: 10,
delay: 10 * time.Millisecond,
}
})
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support retries with a fixed interval backoff.