Skip to content

[ci] update baseline and fix lmdeploy version#2098

Merged
MaiziXiao merged 6 commits intoopen-compass:mainfrom
zhulinJulia24:fix_lmdeploy
May 13, 2025
Merged

[ci] update baseline and fix lmdeploy version#2098
MaiziXiao merged 6 commits intoopen-compass:mainfrom
zhulinJulia24:fix_lmdeploy

Conversation

@zhulinJulia24
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates baseline metrics across several test configuration files and adjusts the CI workflow for lmdeploy, including changes to default values and retry behavior.

  • Updated the default value for building lmdeploy and increased retry attempts in CI workflows.
  • Modified multiple baseline accuracy values in various YAML scripts to reflect new performance figures.
  • Adjusted job conditions in CI to depend on the successful preparation of the environment.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/daily-run-test.yml Updated default value for lmdeploy build, increased retry attempts, and enhanced job conditions.
.github/scripts/oc_score_baseline_testrange.yaml Revised baseline accuracy values for various models.
.github/scripts/oc_score_baseline_fullbench.yaml Updated numerous metrics values across fullbench tests.
.github/scripts/oc_score_baseline.yaml Adjusted demo accuracy and related metrics for lmdeploy tests.
Comments suppressed due to low confidence (3)

.github/workflows/daily-run-test.yml:20

  • Changing the default for 'build lmdeploy' from true to false may impact downstream workflows; please confirm that this is the intended behavior.
default: false

.github/scripts/oc_score_baseline_testrange.yaml:15

  • [nitpick] Confirm that the updated baseline value for 'gsm8k_accuracy' reflects the new performance expectations and is consistent with the results from recent tests.
gsm8k_accuracy: 34.38

.github/scripts/oc_score_baseline.yaml:12

  • [nitpick] Please verify that the updated 'demo_gsm8k_accuracy' metric aligns with the current testing criteria for lmdeploy integration.
demo_gsm8k_accuracy: 84.38


daily_run_test_volc:
if: ${{!cancelled()}}
if: ${{!cancelled() && contains(needs.prepare_env.result, 'success')}}
Copy link

Copilot AI May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The added condition relies on a substring match of the job result; consider using a more explicit status check if supported by the CI system to improve clarity.

Suggested change
if: ${{!cancelled() && contains(needs.prepare_env.result, 'success')}}
if: ${{!cancelled() && needs.prepare_env.result == 'success'}}

Copilot uses AI. Check for mistakes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outdated models like gemma2, internlm2, deepseek v2 can be removed in the later update

Copy link
Contributor

@MaiziXiao MaiziXiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaiziXiao MaiziXiao merged commit d60f59d into open-compass:main May 13, 2025
8 checks passed
stephen-nju pushed a commit to stephen-nju/opencompass that referenced this pull request May 14, 2025
* update

* update

* update

* update

* update

* update
zyc140345 pushed a commit to zyc140345/opencompass that referenced this pull request Oct 23, 2025
* update

* update

* update

* update

* update

* update
iamkaia pushed a commit to iamkaia/opencompass that referenced this pull request Feb 4, 2026
* update

* update

* update

* update

* update

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants