Skip to content

debug rjob runner#2171

Merged
tonysy merged 3 commits intoopen-compass:mainfrom
fly2tomato:develop-rjob
Jun 27, 2025
Merged

debug rjob runner#2171
tonysy merged 3 commits intoopen-compass:mainfrom
fly2tomato:develop-rjob

Conversation

@fly2tomato
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

There is a bug while using rjob to submit task: misconsidering the Starting status of rjob

Modification

take Starting status into consideration in rjob status loop

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

Copy link
Collaborator

@tonysy tonysy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Myhs-phz Myhs-phz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonysy tonysy merged commit bc0480b into open-compass:main Jun 27, 2025
8 checks passed
zyc140345 pushed a commit to zyc140345/opencompass that referenced this pull request Oct 23, 2025
* debug rjob runner

* optimize concurrent requests by adding max_workers

* update

---------

Co-authored-by: xujun <xujun@pjlab.org.cn>
iamkaia pushed a commit to iamkaia/opencompass that referenced this pull request Feb 4, 2026
* debug rjob runner

* optimize concurrent requests by adding max_workers

* update

---------

Co-authored-by: xujun <xujun@pjlab.org.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants