CLI update from diff to compare & add TableComparator by JihwanEom · Pull Request #1012 · open-edge-platform/datumaro

JihwanEom · 2023-05-23T06:45:13Z

Summary

CLI update from diff to compare
Add TableComparator functionality as new method
Refactor existing features for HLOps structure
Fix broken links in project.rst

How to test

datum compare tests/assets/cityscapes_dataset/train_dataset/ tests/assets/ade20k2020_dataset/

# Save output json and testable
datum compare tests/assets/cityscapes_dataset/train_dataset/ tests/assets/ade20k2020_dataset/ --output-dir compare_test

Output preview

$ datum compare tests/assets/cityscapes_dataset/train_dataset/ tests/assets/ade20k2020_dataset/
High-level comparison:
+--------------------------+-------------------------------------+------------------------+
| Field                    | First                               | Second                 |
+==========================+=====================================+========================+
| Format                   | cityscapes                          | ade20k2020             |
+--------------------------+-------------------------------------+------------------------+
| Number of classes        | 20                                  | 4                      |
+--------------------------+-------------------------------------+------------------------+
| Common classes           | car, person                         | car, person            |
+--------------------------+-------------------------------------+------------------------+
| Classes                  | background, bicycle, building, bus, | car, door, person, rim |
|                          | car, fence, motorcycle, person,     |                        |
|                          | pole, rider, road, sidewalk, sky,   |                        |
|                          | terrain, trafficlight, trafficsign, |                        |
|                          | train, truck, vegetation, wall      |                        |
+--------------------------+-------------------------------------+------------------------+
| Images count             | 4                                   | 3                      |
+--------------------------+-------------------------------------+------------------------+
| Unique images count      | 1                                   | 1                      |
+--------------------------+-------------------------------------+------------------------+
| Repeated images count    | 1                                   | 1                      |
+--------------------------+-------------------------------------+------------------------+
| Annotations count        | 8                                   | 22                     |
+--------------------------+-------------------------------------+------------------------+
| Unannotated images count | 0                                   | 0                      |
+--------------------------+-------------------------------------+------------------------+

Mid-level comparison:
+-------------------------------------+--------------------------+--------------------------+
| Field                               | First                    | Second                   |
+=====================================+==========================+==========================+
| test - Image Mean                   | 1.00,   1.00,   1.00     |                          |
+-------------------------------------+--------------------------+--------------------------+
| test - Image Std                    | 0.00,   0.00,   0.00     |                          |
+-------------------------------------+--------------------------+--------------------------+
| train - Image Mean                  | 1.00,   1.00,   1.00     |                          |
+-------------------------------------+--------------------------+--------------------------+
| train - Image Std                   | 0.00,   0.00,   0.00     |                          |
+-------------------------------------+--------------------------+--------------------------+
| val - Image Mean                    | 1.00,   1.00,   1.00     |                          |
+-------------------------------------+--------------------------+--------------------------+
| val - Image Std                     | 0.00,   0.00,   0.00     |                          |
+-------------------------------------+--------------------------+--------------------------+
| dataset - Image Mean                |                          | 1.00,   1.00,   1.00     |
+-------------------------------------+--------------------------+--------------------------+
| dataset - Image Std                 |                          | 0.00,   0.00,   0.00     |
+-------------------------------------+--------------------------+--------------------------+
| dataset_with_meta_file - Image Mean |                          | 1.00,   1.00,   1.00     |
+-------------------------------------+--------------------------+--------------------------+
| dataset_with_meta_file - Image Std  |                          | 0.00,   0.00,   0.00     |
+-------------------------------------+--------------------------+--------------------------+
| Label - background                  | imgs: 4, percent: 0.5000 |                          |
+-------------------------------------+--------------------------+--------------------------+
| Label - bicycle                     |                          |                          |
+-------------------------------------+--------------------------+--------------------------+
| Label - building                    |                          |                          |
+-------------------------------------+--------------------------+--------------------------+
| Label - bus                         |                          |                          |
+-------------------------------------+--------------------------+--------------------------+
| Label - car                         |                          | imgs: 6, percent: 0.2727 |
+-------------------------------------+--------------------------+--------------------------+
| Label - fence                       |                          |                          |
+-------------------------------------+--------------------------+--------------------------+
| Label - motorcycle                  |                          |                          |
+-------------------------------------+--------------------------+--------------------------+
| Label - person                      | imgs: 1, percent: 0.1250 | imgs: 8, percent: 0.3636 |
+-------------------------------------+--------------------------+--------------------------+
| Label - pole                        |                          |                          |
+-------------------------------------+--------------------------+--------------------------+
| Label - rider                       |                          |                          |
+-------------------------------------+--------------------------+--------------------------+
| Label - road                        |                          |                          |
+-------------------------------------+--------------------------+--------------------------+
| Label - sidewalk                    |                          |                          |
+-------------------------------------+--------------------------+--------------------------+
| Label - sky                         |                          |                          |
+-------------------------------------+--------------------------+--------------------------+
| Label - terrain                     |                          |                          |
+-------------------------------------+--------------------------+--------------------------+
| Label - trafficlight                |                          |                          |
+-------------------------------------+--------------------------+--------------------------+
| Label - trafficsign                 |                          |                          |
+-------------------------------------+--------------------------+--------------------------+
| Label - train                       | imgs: 1, percent: 0.1250 |                          |
+-------------------------------------+--------------------------+--------------------------+
| Label - truck                       | imgs: 1, percent: 0.1250 |                          |
+-------------------------------------+--------------------------+--------------------------+
| Label - vegetation                  |                          |                          |
+-------------------------------------+--------------------------+--------------------------+
| Label - wall                        | imgs: 1, percent: 0.1250 |                          |
+-------------------------------------+--------------------------+--------------------------+
| Label - door                        |                          | imgs: 6, percent: 0.2727 |
+-------------------------------------+--------------------------+--------------------------+
| Label - rim                         |                          | imgs: 2, percent: 0.0909 |
+-------------------------------------+--------------------------+--------------------------+

Low-level comparison:
+-----------------+---------+
| Field           |   Value |
+=================+=========+
| Covariate shift |   0     |
+-----------------+---------+
| Label shift     |   0.999 |
+-----------------+---------+

Test coverage

Name                                                                                   Stmts   Miss Branch BrPart  Cover
------------------------------------------------------------------------------------------------------------------------
datumaro/plugins/comparator.py                                                           321     37    120      8    87%

How to test

Checklist

I have added unit tests to cover my changes.
I have added integration tests to cover my changes.
I have added the description of my changes into CHANGELOG.
I have updated the documentation accordingly

License

I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
I have updated the license header for each file (see an example below).

# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

…jeom/comparator

datumaro/cli/commands/compare.py

JihwanEom · 2023-06-03T12:25:14Z

Could you clarify the differences between DistanceComparator, EqualityComparator, and TableComparator?

The DistanceComparator supports item-wise comparison for the label, bbox, polygon, and mask annotation types, and it saves a confusion matrix for each type.
The EqualityComparator is used to compare whether the annotations in two given datasets are exactly the same.
The TableComparator is a new feature proposed in this PR. It provides a high-level view of the datasets, not on an item-wise basis, but on the overall perspective. TableComparator represents the dataset's format, number of classes, common classes, and image count. In the mid-level view, it presents image and annotation statistics for each subset. In the low-level comparison, it utilizes a shift analyzer to represent covariate shift and label shift.

Below are examples of the output for each comparator.

datum compare tests/assets/ade20k2017_dataset/ tests/assets/ade20k2020_dataset/ --method distance --output-dir output/distance
datum compare tests/assets/ade20k2017_dataset/ tests/assets/ade20k2020_dataset/ --method equality --output-dir output/equality 
datum compare tests/assets/ade20k2017_dataset/ tests/assets/ade20k2020_dataset/ --method table --output-dir output/table

DistanceComparator

mask_confusion.png

polygon_confusion.png

EqualityComparator

equality_compare.json

{
  "mismatches": [],
  "a_extra_items": [],
  "b_extra_items": [],
  "errors": [
    {
      "type": "labels",
      "message": "Lists differ: [Labe[22 chars]ame='sky', parent='', attributes=set()), Label[203 chars]t())] != [Labe[22 chars]ame='car', parent='', attributes=set()), Label[194 chars]t())]\n\nFirst differing element 0:\nLabelCategories.Category(name='sky', parent='', attributes=set())\nLabelCategories.Category(name='car', parent='', attributes=set())\n\n- [LabelCategories.Category(name='sky', parent='', attributes=set()),\n?                                 ^^^\n\n+ [LabelCategories.Category(name='car', parent='', attributes=set()),\n?                                 ^^^\n\n   LabelCategories.Category(name='person', parent='', attributes=set()),\n-  LabelCategories.Category(name='license plate', parent='', attributes=set()),\n?                                 ^^^^^^^^^^^^^\n\n+  LabelCategories.Category(name='door', parent='', attributes=set()),\n?                                 ^^^^\n\n   LabelCategories.Category(name='rim', parent='', attributes=set())]"
    }
  ]
}

TableComparator

table_compare.txt

High-level Comparison:
+--------------------------+---------------------------------+------------------------+
| Field                    | First                           | Second                 |
+==========================+=================================+========================+
| Format                   | ade20k2017                      | ade20k2020             |
+--------------------------+---------------------------------+------------------------+
| Number of classes        | 4                               | 4                      |
+--------------------------+---------------------------------+------------------------+
| Common classes           | person, rim                     | person, rim            |
+--------------------------+---------------------------------+------------------------+
| Classes                  | license plate, person, rim, sky | car, door, person, rim |
+--------------------------+---------------------------------+------------------------+
| Images count             | 3                               | 3                      |
+--------------------------+---------------------------------+------------------------+
| Unique images count      | 1                               | 1                      |
+--------------------------+---------------------------------+------------------------+
| Repeated images count    | 1                               | 1                      |
+--------------------------+---------------------------------+------------------------+
| Annotations count        | 10                              | 22                     |
+--------------------------+---------------------------------+------------------------+
| Unannotated images count | 0                               | 0                      |
+--------------------------+---------------------------------+------------------------+

Mid-level Comparison:
+-------------------------------------+--------------------------+--------------------------+
| Field                               | First                    | Second                   |
+=====================================+==========================+==========================+
| dataset - Image Mean                | 1.00,   1.00,   1.00     | 1.00,   1.00,   1.00     |
+-------------------------------------+--------------------------+--------------------------+
| dataset - Image Std                 | 0.00,   0.00,   0.00     | 0.00,   0.00,   0.00     |
+-------------------------------------+--------------------------+--------------------------+
| dataset_with_meta_file - Image Mean | 1.00,   1.00,   1.00     | 1.00,   1.00,   1.00     |
+-------------------------------------+--------------------------+--------------------------+
| dataset_with_meta_file - Image Std  | 0.00,   0.00,   0.00     | 0.00,   0.00,   0.00     |
+-------------------------------------+--------------------------+--------------------------+
| Label - license plate               | imgs: 3, percent: 0.3000 |                          |
+-------------------------------------+--------------------------+--------------------------+
| Label - person                      | imgs: 3, percent: 0.3000 | imgs: 8, percent: 0.3636 |
+-------------------------------------+--------------------------+--------------------------+
| Label - rim                         | imgs: 1, percent: 0.1000 | imgs: 2, percent: 0.0909 |
+-------------------------------------+--------------------------+--------------------------+
| Label - sky                         | imgs: 3, percent: 0.3000 |                          |
+-------------------------------------+--------------------------+--------------------------+
| Label - car                         |                          | imgs: 6, percent: 0.2727 |
+-------------------------------------+--------------------------+--------------------------+
| Label - door                        |                          | imgs: 6, percent: 0.2727 |
+-------------------------------------+--------------------------+--------------------------+

Low-level Comparison:
+-----------------+---------+
| Field           |   Value |
+=================+=========+
| Covariate shift |    0    |
+-----------------+---------+
| Label shift     |    0.75 |
+-----------------+---------+

datumaro/plugins/comparator.py

datumaro/plugins/shift_analyzer.py

…jeom/comparator

src/datumaro/plugins/openvino_plugin/shift_launcher.py

vinnamkim

LGTM.

…jeom/comparator

- Resolve #1065 - `tabulate` was introduced in #1012, but not added to requirements-core.txt - The reason why we haven't found it is because `tabulate` is dependency of `dvc`, so that there has been no problem if we install `datumaro[default]`. Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>

JihwanEom added 11 commits May 18, 2023 18:16

Initial commit for comparator

a0ece5d

Refactor structure

51fc2ce

Remove data

28e09b1

Update comparator

7784961

Update pre-commit

0992184

Python API for comparator

cefde0c

Finalize code lines

b070417

Refactor & update docstrings

d98d44c

Fix ordering

ab8f01d

Merge branch 'develop' of https://github.com/JihwanEom/datumaro into …

90163e6

…jeom/comparator

Revert pre-commit

56505ee

JihwanEom changed the base branch from develop to releases/1.3.0 May 23, 2023 06:49

vinnamkim suggested changes May 23, 2023

View reviewed changes

datumaro/cli/commands/compare.py Show resolved Hide resolved

JihwanEom changed the base branch from releases/1.3.0 to develop May 24, 2023 05:46

JihwanEom added 7 commits May 25, 2023 21:10

Replace texttable with tabulate

2bfaa33

Revert existed feture

c15b927

Revert features

a6ba92a

Update documents

76ec95f

Align interface

e08d363

Update HLOps

3630b71

Fix tests

e637cfa

JihwanEom changed the title ~~Add comparator~~ CLI Update from diff to compare & add TableComparator May 25, 2023

JihwanEom changed the title ~~CLI Update from diff to compare & add TableComparator~~ CLI update from diff to compare & add TableComparator May 25, 2023

JihwanEom changed the title ~~CLI update from diff to compare & add TableComparator~~ CLI update diff => compare & add TableComparator May 25, 2023

JihwanEom changed the title ~~CLI update diff => compare & add TableComparator~~ CLI update from diff to compare & add TableComparator May 25, 2023

JihwanEom added 5 commits May 26, 2023 08:09

Fix HLOps

6927999

Update type hint

624aa1f

Resolve EqualityComparator bug

01940cc

Add unit test

28a1d1b

Rename visualizer & update changelog

7dc92df

wonjuleee previously approved these changes Jun 5, 2023

View reviewed changes

sooahleex previously approved these changes Jun 5, 2023

View reviewed changes

vinnamkim reviewed Jun 5, 2023

View reviewed changes

datumaro/plugins/comparator.py Show resolved Hide resolved

vinnamkim reviewed Jun 5, 2023

View reviewed changes

datumaro/plugins/shift_analyzer.py Show resolved Hide resolved

Reflect review comments

d9f71a5

JihwanEom dismissed stale reviews from sooahleex and wonjuleee via d9f71a5 June 5, 2023 06:49

Fix pre-commit issue

ebc0326

JihwanEom requested review from sooahleex, vinnamkim and wonjuleee June 5, 2023 07:02

Merge branch 'develop' of https://github.com/JihwanEom/datumaro into …

dfdbb06

…jeom/comparator

vinnamkim added this to the 1.4.0 milestone Jun 5, 2023

vinnamkim added FEATURE refactoring labels Jun 5, 2023

JihwanEom marked this pull request as draft June 7, 2023 01:52

JihwanEom marked this pull request as ready for review June 7, 2023 02:10

vinnamkim reviewed Jun 7, 2023

View reviewed changes

src/datumaro/plugins/openvino_plugin/shift_launcher.py Show resolved Hide resolved

vinnamkim approved these changes Jun 7, 2023

View reviewed changes

sooahleex approved these changes Jun 7, 2023

View reviewed changes

JihwanEom merged commit a702d61 into open-edge-platform:develop Jun 7, 2023

JihwanEom added 6 commits June 7, 2023 19:04

Resolve failed TC

4776abd

Merge branch 'develop' of https://github.com/JihwanEom/datumaro into …

a3bedee

…jeom/comparator

Resolve rebase issue

5691713

Update specs.json

9cf06aa

Resolve pre-commit issue

e907c5a

Remove duplicated file

e9d7a31

vinnamkim mentioned this pull request Jun 28, 2023

Add tabulate to requirements-core.txt #1066

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CLI update from diff to compare & add TableComparator#1012

CLI update from diff to compare & add TableComparator#1012
JihwanEom merged 43 commits intoopen-edge-platform:developfrom
JihwanEom:jeom/comparator

JihwanEom commented May 23, 2023 •

edited

Loading

Uh oh!

Uh oh!

JihwanEom commented Jun 3, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vinnamkim left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

JihwanEom commented May 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

How to test

Output preview

Test coverage

How to test

Checklist

License

Uh oh!

Uh oh!

JihwanEom commented Jun 3, 2023

DistanceComparator

EqualityComparator

TableComparator

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vinnamkim left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

JihwanEom commented May 23, 2023 •

edited

Loading