Skip to content

add boxes-to-polygons transform#1119

Merged
jihyeonyi merged 2 commits intoopen-edge-platform:developfrom
jihyeonyi:bbox_to_polygon
Aug 9, 2023
Merged

add boxes-to-polygons transform#1119
jihyeonyi merged 2 commits intoopen-edge-platform:developfrom
jihyeonyi:bbox_to_polygon

Conversation

@jihyeonyi
Copy link
Copy Markdown

@jihyeonyi jihyeonyi commented Aug 9, 2023

Summary

Add bbox to polygon transform.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@jihyeonyi jihyeonyi marked this pull request as ready for review August 9, 2023 01:50
@jihyeonyi jihyeonyi requested review from a team as code owners August 9, 2023 01:50
@jihyeonyi jihyeonyi requested review from wonjuleee and removed request for a team August 9, 2023 01:50
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c84a13d) 80.00% compared to head (7f1b93c) 80.01%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1119   +/-   ##
========================================
  Coverage    80.00%   80.01%           
========================================
  Files          258      258           
  Lines        29329    29336    +7     
  Branches      5745     5746    +1     
========================================
+ Hits         23465    23473    +8     
  Misses        4516     4516           
+ Partials      1348     1347    -1     
Flag Coverage Δ
macos-11_Python-3.8 79.10% <100.00%> (+<0.01%) ⬆️
ubuntu-20.04_Python-3.8 79.99% <100.00%> (+<0.01%) ⬆️
windows-2019_Python-3.8 79.92% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/datumaro/plugins/transforms.py 76.52% <100.00%> (+0.23%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jihyeonyi jihyeonyi merged commit 5f5ac2a into open-edge-platform:develop Aug 9, 2023
@jihyeonyi jihyeonyi deleted the bbox_to_polygon branch August 9, 2023 08:36
@jihyeonyi jihyeonyi added this to the 1.5.0 milestone Aug 11, 2023
@jihyeonyi jihyeonyi added the enhancement Enhancement of existing features label Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement of existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants