Allow empty label on Ultralytics YOLO dataset#1264
Merged
vinnamkim merged 1 commit intoopen-edge-platform:developfrom Feb 7, 2024
Merged
Allow empty label on Ultralytics YOLO dataset#1264vinnamkim merged 1 commit intoopen-edge-platform:developfrom
vinnamkim merged 1 commit intoopen-edge-platform:developfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1264 +/- ##
===========================================
- Coverage 80.54% 80.54% -0.01%
===========================================
Files 271 271
Lines 30438 30457 +19
Branches 5930 5932 +2
===========================================
+ Hits 24517 24532 +15
- Misses 4532 4536 +4
Partials 1389 1389
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vinnamkim
approved these changes
Feb 7, 2024
Contributor
vinnamkim
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing what we missed.
Merged
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In Ultralytics YOLO dataset, there is no label required for the background images. But in
datumaro, the_check_ann_file_implof the_YoloLooseImporterclass will filter all empty label.txtand does not search for images without label.txt. This PR will not search for images without label.txtbut will add images with empty label.txtto the dataset.How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.