Add KaggleCoco and Bbox capability in KaggleImageCsv and KaggleImageTxt#1273
Merged
wonjuleee merged 12 commits intoopen-edge-platform:developfrom Feb 28, 2024
Merged
Add KaggleCoco and Bbox capability in KaggleImageCsv and KaggleImageTxt#1273wonjuleee merged 12 commits intoopen-edge-platform:developfrom
wonjuleee merged 12 commits intoopen-edge-platform:developfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1273 +/- ##
===========================================
+ Coverage 80.76% 80.77% +0.01%
===========================================
Files 270 271 +1
Lines 30599 30664 +65
Branches 6179 6190 +11
===========================================
+ Hits 24713 24770 +57
- Misses 4499 4503 +4
- Partials 1387 1391 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sooahleex
approved these changes
Feb 27, 2024
Contributor
sooahleex
left a comment
sooahleex
left a comment
There was a problem hiding this comment.
Overall structure looks good to me. I just left some minor comments.
| return [float(coord.strip()) for coord in coords] | ||
|
|
||
| def _load_annotations(self, datas: list, indices: Dict[str, int], bbox_flag: bool): | ||
| if "label" in indices: |
Contributor
There was a problem hiding this comment.
Suggested change
| if "label" in indices: | |
| label_index = indices.get("label", None) |
It seems better to get label index or use default value to avoid check this twice.
Comment on lines
+128
to
+129
| if "label" in columns: | ||
| indices.update({"label": df_fields.index(columns["label"])}) |
Contributor
There was a problem hiding this comment.
Suggested change
| if "label" in columns: | |
| indices.update({"label": df_fields.index(columns["label"])}) | |
| label_index = columns.get("label") | |
| if label_index: | |
| indices["label"] = df_fields.index(label_index) |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
wonjuleee
force-pushed
the
add_kaggle_det
branch
from
518f17a to
0fd2c31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.