Add DatasetImportError for yolo variants#1362
Merged
wonjuleee merged 4 commits intoopen-edge-platform:releases/2.0.0from Mar 20, 2024
Merged
Add DatasetImportError for yolo variants#1362wonjuleee merged 4 commits intoopen-edge-platform:releases/2.0.0from
wonjuleee merged 4 commits intoopen-edge-platform:releases/2.0.0from
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## releases/2.0.0 #1362 +/- ##
=================================================
Coverage ? 80.85%
=================================================
Files ? 271
Lines ? 30689
Branches ? 6197
=================================================
Hits ? 24814
Misses ? 4489
Partials ? 1386
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vinnamkim
reviewed
Mar 20, 2024
7edfe93 to
dfe2bc0
Compare
vinnamkim
approved these changes
Mar 20, 2024
Co-authored-by: Vinnam Kim <vinnam.kim@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Datumaro is able to import a dataset from extractor directly as described in https://github.com/openvinotoolkit/datumaro/blob/f9366173a0a5ba6fe479703800a2f3a0caf15530/src/datumaro/components/dataset.py#L822
However, in this case, we have to be careful for importing a dataset.
For instance, Yolo extractors, i.e.,
YoloLooseBase,YoloUltralyticsBase,RoboflowYoloBase, andRoboflowYoloObbBase, require to haveurlsfor specifying subset and all annotation files accordingly.In this PR, I have added
DatasetImportErrorwhen importing a Yolo dataset withouturls.How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.