Skip to content

Support annotation types instead of task type#1479

Merged
wonjuleee merged 6 commits intoopen-edge-platform:developfrom
wonjuleee:fix_task_types
Apr 30, 2024
Merged

Support annotation types instead of task type#1479
wonjuleee merged 6 commits intoopen-edge-platform:developfrom
wonjuleee:fix_task_types

Conversation

@wonjuleee
Copy link
Copy Markdown
Contributor

@wonjuleee wonjuleee commented Apr 26, 2024

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT

@wonjuleee wonjuleee requested review from a team as code owners April 26, 2024 05:56
@wonjuleee wonjuleee requested review from vinnamkim and removed request for a team April 26, 2024 05:56
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 85.39326% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 80.78%. Comparing base (44cc56a) to head (8bc75d1).
Report is 47 commits behind head on develop.

Files Patch % Lines
src/datumaro/plugins/data_formats/datumaro/base.py 61.53% 5 Missing ⚠️
...umaro/plugins/data_formats/datumaro/page_mapper.py 50.00% 3 Missing ⚠️
src/datumaro/components/dataset_storage.py 88.88% 2 Missing ⚠️
src/datumaro/components/dataset.py 75.00% 1 Missing ⚠️
src/datumaro/components/dataset_base.py 83.33% 1 Missing ⚠️
src/datumaro/components/dataset_item_storage.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1479      +/-   ##
===========================================
- Coverage    80.85%   80.78%   -0.08%     
===========================================
  Files          271      272       +1     
  Lines        30689    31181     +492     
  Branches      6197     6288      +91     
===========================================
+ Hits         24815    25189     +374     
- Misses        4489     4580      +91     
- Partials      1385     1412      +27     
Flag Coverage Δ
ubuntu-20.04_Python-3.10 80.76% <85.39%> (-0.08%) ⬇️
windows-2022_Python-3.10 80.75% <85.39%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wonjuleee wonjuleee merged commit e1ecf6c into open-edge-platform:develop Apr 30, 2024
@wonjuleee wonjuleee added this to the 1.7.0 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants