Skip to content

Set label name with parents to avoid duplicates for AstypeAnnotations#1492

Merged
sooahleex merged 5 commits intoopen-edge-platform:developfrom
sooahleex:fix/labelname_astypetransform
May 9, 2024
Merged

Set label name with parents to avoid duplicates for AstypeAnnotations#1492
sooahleex merged 5 commits intoopen-edge-platform:developfrom
sooahleex:fix/labelname_astypetransform

Conversation

@sooahleex
Copy link
Copy Markdown
Contributor

@sooahleex sooahleex commented May 8, 2024

Summary

  • Except nan for label
  • Set label name with parents to avoid duplicate name for AstypeAnnotations

How to test

  • Add unit test when tabular dataset included missing value
  • Add unit test for AstypeAnnotations when label value is nan

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT

@sooahleex sooahleex marked this pull request as ready for review May 8, 2024 08:42
@sooahleex sooahleex requested review from a team as code owners May 8, 2024 08:42
@sooahleex sooahleex requested review from jihyeonyi and removed request for a team May 8, 2024 08:42
@codecov
Copy link
Copy Markdown

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.62%. Comparing base (44cc56a) to head (4042077).
Report is 58 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1492      +/-   ##
===========================================
- Coverage    80.85%   80.62%   -0.24%     
===========================================
  Files          271      276       +5     
  Lines        30689    31369     +680     
  Branches      6197     6313     +116     
===========================================
+ Hits         24815    25291     +476     
- Misses        4489     4663     +174     
- Partials      1385     1415      +30     
Flag Coverage Δ
ubuntu-20.04_Python-3.10 80.62% <100.00%> (-0.22%) ⬇️
windows-2022_Python-3.10 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sooahleex sooahleex force-pushed the fix/labelname_astypetransform branch from 47e8a47 to 4042077 Compare May 9, 2024 02:20
@sooahleex sooahleex merged commit 072c8a8 into open-edge-platform:develop May 9, 2024
vinnamkim pushed a commit to vinnamkim/datumaro that referenced this pull request May 17, 2024
…open-edge-platform#1492)

- Except `nan` for label
- Set label name with parents to avoid duplicate name for `AstypeAnnotations`
- Add unit test when tabular dataset included missing value
- Add unit test for AstypeAnnotations when label value is nan
@sooahleex sooahleex added this to the 1.8.0 milestone Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants